Re: [PATCH 1/8] fbdev/smscufx: Use fb_ops helpers for deferred I/O
From: Javier Martinez Canillas <javierm@redhat.com>
Date: 2023-09-04 13:00:17
Also in:
dri-devel, linux-fbdev, linux-hyperv, linux-staging
Thomas Zimmermann [off-list ref] writes: Hello Thomas,
Generate callback functions for struct fb_ops with the fbdev macro FB_GEN_DEFAULT_DEFERRED_SYSMEM_OPS(). Initialize struct fb_ops to the generated functions with fbdev initializer macros. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Cc: Steve Glendinning <steve.glendinning@shawell.net> ---
The patch looks good to me, but I've a question below. Acked-by: Javier Martinez Canillas <javierm@redhat.com>
quoted hunk ↗ jump to hunk
drivers/video/fbdev/smscufx.c | 85 +++++++++-------------------------- 1 file changed, 22 insertions(+), 63 deletions(-)diff --git a/drivers/video/fbdev/smscufx.c b/drivers/video/fbdev/smscufx.c
[...]
static const struct fb_ops ufx_ops = {
.owner = THIS_MODULE,
- .fb_read = fb_sys_read,
- .fb_write = ufx_ops_write,
+ __FB_DEFAULT_DEFERRED_OPS_RDWR(ufx_ops),
.fb_setcolreg = ufx_ops_setcolreg,
- .fb_fillrect = ufx_ops_fillrect,
- .fb_copyarea = ufx_ops_copyarea,
- .fb_imageblit = ufx_ops_imageblit,
+ __FB_DEFAULT_DEFERRED_OPS_DRAW(ufx_ops),
.fb_mmap = ufx_ops_mmap,There are no generated functions for .fb_mmap, I wonder what's the value of __FB_DEFAULT_DEFERRED_OPS_MMAP() ? Maybe just removing that macro and setting .fb_mmap = fb_deferred_io_mmap instead if there's no custom mmap handler would be easier to read ? Alternatively, __FB_DEFAULT_DEFERRED_OPS_MMAP() could still be left but not taking a __prefix argument since that is not used anyways ? -- Best regards, Javier Martinez Canillas Core Platforms Red Hat