Re: [PATCH v4 3/3] input: pm8xxx-vibrator: add new SPMI vibrator support

From
Krzysztof Kozlowski <hidden>
Date
2023-08-14 10:08:47
Also in
linux-arm-msm, lkml
Reply to
Fenglin Wu, 2023-07-31
On 31/07/2023 07:37, Fenglin Wu wrote:

...
quoted hunk ↗ jump to hunk
 
 	pm8xxx_vib_set(vib, vib->active);
@@ -266,6 +310,7 @@ static const struct of_device_id pm8xxx_vib_id_table[] = {
 	{ .compatible = "qcom,pm8058-vib", .data = &ssbi_vib_data },
 	{ .compatible = "qcom,pm8921-vib", .data = &ssbi_vib_data },
 	{ .compatible = "qcom,pm8916-vib", .data = &spmi_vib_data },
+	{ .compatible = "qcom,spmi-vib-gen2", .data = &spmi_vib_gen2_data },
No, don't introduce new style of compatibles. All of the other cases use
device-specific compatibles. Keep style consistent, especially that
device specific is preferred.

Best regards,
Krzysztof
Thread (2 messages) 2 messages, 2 authors, last reply 2023-08-14
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help