Re: [PATCH] hid: Add "Hailuck" to the list of non-apple apple keyboards
From: Rahul Rameshbabu <hidden>
Date: 2023-08-14 05:12:20
Also in:
lkml
On Fri, 11 Aug, 2023 13:29:31 -0700 "Nils Tonnaett" [off-list ref] wrote:
Powzan keyboards KB750 and KB770 identify as "Hailuck Co.,Ltd USB Keyboard". Adding "Hailuck" to the list of non-apple apple keyboards fixes function keys for these models. Signed-off-by: Nils Tonnaett <redacted> ---
You will likely want to resubmit this patch using "HID: apple:" in place of "hid:" in the commit message subject. https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/log/drivers/hid/hid-apple.c
quoted hunk ↗ jump to hunk
drivers/hid/hid-apple.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c index d7b932925730..6664f90cecaf 100644 --- a/drivers/hid/hid-apple.c +++ b/drivers/hid/hid-apple.c@@ -343,7 +343,8 @@ static const struct apple_non_apple_keyboard non_apple_keyboards[] = { { "SONiX USB DEVICE" }, { "Keychron" }, { "AONE" }, - { "GANSS" } + { "GANSS" }, + { "Hailuck" }
This isn't a must, but maybe it makes sense to comma terminate the last member in this array specifically if you will be resubmitting this change as a v2. This way, future keyboards added will only touch one line in the patch rather than two.
}; static bool apple_is_non_apple_keyboard(struct hid_device *hdev)
-- Thanks, Rahul Rameshbabu