Thread (7 messages) 7 messages, 4 authors, 2023-06-13

Re: [PATCH 2/2] Input: cap11xx - add advanced sensitivity settings

From: Jiri Valek - 2N <hidden>
Date: 2023-06-13 13:28:41
Also in: linux-devicetree, lkml

Hi Dmitry,

On 5/12/23 01:57, Dmitry Torokhov wrote:
Hi Jiri,

On Sat, Apr 15, 2023 at 01:38:15AM +0200, Jiri Valek - 2N wrote:
quoted
@@ -474,7 +645,7 @@ static int cap11xx_i2c_probe(struct i2c_client *i2c_client)
 	if (error)
 		return error;
 
-	irq = irq_of_parse_and_map(node, 0);
+	irq = irq_of_parse_and_map(dev->of_node, 0);
Do you know if this is actually needed or we can rely on I2C core to
figure out the interrupt for us?
Agree and verified that's really not needed. I2C core do the job.
I will remove it.
Also, could I ask you to move the driver from of_property_*() to
device_property_*() API?
And yes. I can move it to device_property API.

I prepare the changes as separate commits after I solve issues
with my "add advanced sensitivity settings" patch.
Thanks.
BR,
Jiri Valek
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help