Thread (17 messages) 17 messages, 6 authors, 2023-06-14

Re: [PATCH v4 1/4] Input: ads7846 - Convert to use software nodes

From: Linus Walleij <hidden>
Date: 2023-06-06 19:15:41
Also in: dri-devel, linux-arm-kernel, linux-fbdev, linux-mips, linux-mmc, linux-omap, linux-spi, lkml

On Sun, Jun 4, 2023 at 5:44 PM Christophe JAILLET
[off-list ref] wrote:
quoted
+     /* Asserts RESET */
+     gpiod_set_value(md->reset, 1);
Hi,

should this also be done in the probe if mipid_detect() fails?
It's a nice bonus but surely not urgent or necessary.
If yes, please also look at [1], that I've just sent, which introduces
an error handling path in the probe.
Looks good to me.
Reviewed-by: Linus Walleij <redacted>

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help