Re: [PATCH v1 28/43] input: keypad: ep93xx: add DT support for Cirrus EP93xx
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2023-06-01 16:55:13
Also in:
lkml
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2023-06-01 16:55:13
Also in:
lkml
On Thu, Jun 01, 2023 at 08:45:33AM +0300, Nikita Shubin wrote:
- get keymap from the device tree - find register range from the device tree - get interrupts from device tree
...
+/* flags for the ep93xx_keypad driver */ +#define EP93XX_KEYPAD_DISABLE_3_KEY (1<<0) /* disable 3-key reset */ +#define EP93XX_KEYPAD_DIAG_MODE (1<<1) /* diagnostic mode */ +#define EP93XX_KEYPAD_BACK_DRIVE (1<<2) /* back driving mode */ +#define EP93XX_KEYPAD_TEST_MODE (1<<3) /* scan only column 0 */ +#define EP93XX_KEYPAD_AUTOREPEAT (1<<4) /* enable key autorepeat */
+static int ep93xx_keypad_flags; +module_param(ep93xx_keypad_flags, int, 0); +MODULE_PARM_DESC(ep93xx_keypad_flags, "EP93XX keypad flags.");
Why? This pretty much looks like missing DT description. Please, write your commit message better, so we can understand the point of such decisions w/o asking. -- With Best Regards, Andy Shevchenko