On Dienstag, 2. Mai 2023 12:39:10 CEST Konrad Dybcio wrote:

On 28.04.2023 18:06, Luca Weiss wrote:

quoted

On Freitag, 28. April 2023 01:29:27 CEST Brian Masney wrote:

quoted

On Thu, Apr 27, 2023 at 10:34:28PM +0200, Luca Weiss wrote:

quoted

Some pwm vibrators have a dedicated enable GPIO that needs to be set
high so that the vibrator works. Add support for that optionally.

Signed-off-by: Luca Weiss <redacted>

Hi Luca,

Thank you for picking up this work!

quoted

+	vibrator->enable_gpio = devm_gpiod_get_optional(&pdev->dev,

"enable",

quoted

quoted

+

GPIOD_OUT_LOW);

quoted

quoted

+	err = PTR_ERR_OR_ZERO(vibrator->enable_gpio);
+	if (err) {
+		if (err != -EPROBE_DEFER)
+			dev_err(&pdev->dev, "Failed to request enable

gpio: %d\n",

quoted

quoted

+				err);
+		return err;
+	}
+

Looks like your email client messes with the replies.. perhaps it tries
to round them to n characters forcefully?

Quite possible, I'm using KMail with Options -> Wordwrap turned on, otherwise 
I have to manually wrap everything but with this on there doesn't seem to be a 
way to get over that limit, even when posting links etc - or when quoting 
existing text.

Regards
Luca

Konrad

quoted

quoted

Take a look at dev_err_probe() to remove the -EPROBE_DEFER check.

The input subsystem doesn't like dev_err_probe for some reason, you should
quickly find examples of that being rejected on the mailing list (or see
"git grep dev_err_probe drivers/input/")

quoted

With that fixed:

Reviewed-by: Brian Masney <bmasney@redhat.com>

Thanks for the reviews!