Thread (6 messages) 6 messages, 5 authors, 2023-03-15

Re: [PATCH v2] Fix buffer overrun in HID-SENSOR name string

From: Todd Brandt <todd.e.brandt@linux.intel.com>
Date: 2023-03-15 20:35:53
Also in: linux-iio, lkml

On Wed, 2023-03-15 at 08:04 +0100, Krzysztof Kozlowski wrote:
On 13/03/2023 23:06, Todd Brandt wrote:
quoted
On some platforms there are some platform devices created with
invalid names. For example: "HID-SENSOR-INT-020b?.39.auto" instead
of "HID-SENSOR-INT-020b.39.auto"

This string include some invalid characters, hence it will fail to
properly load the driver which will handle this custom sensor. Also
it is a problem for some user space tools, which parse the device
names from ftrace and dmesg.

This is because the string, real_usage, is not NULL terminated and
printed with %s to form device name.

To address this, we initialize the real_usage string with 0s.

Philipp Jungkamp created this fix, I'm simply submitting it. I've
verified it fixes bugzilla issue 217169

Reported-and-tested-by: Todd Brandt <todd.e.brandt@linux.intel.com>
Signed-off-by: Todd Brandt <redacted>
SoB denotes that you reported this and tested. Otherwise shall we
start
adding Reported and Tested tags to all of our commits?
I just copied it from someone else's post on the mailing list, I
thought it was part of the standard lkml vernacular but I just looked
it up and it's explicitly forbidden in
Documentation/process/maintainer-top.rst line 385. So the answer is no.
I'll not use it again.
Best regards,
Krzysztof
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help