Re: [PATCH] HID: sony: Fix division by zero
From: Alain Carlucci <hidden>
Date: 2023-01-05 18:24:04
Hi Roderick, I just tried to see with evtest the values of gyro/accel after changing the driver so that follows the suggestion on the dsremap website: dividing by two speed_2x: speed_2x = (gyro_speed_plus + gyro_speed_minus) >> 1; The DS4 shows values no higher than 600000 (post-calibration) while heavily shaking the joystick. For the record, the calibration is: gyro_pitch_plus: 8848 gyro_pitch_minus: -8853 gyro_yaw_plus: 8833 gyro_yaw_minus: -8827 gyro_roll_plus: 8856 gyro_roll_minus: -8841 gyro_speed_plus: 540 gyro_speed_minus: 540 acc_x_plus: 8107 acc_x_minus: -8107 acc_y_plus: 8259 acc_y_minus: -8259 acc_z_plus: 8187 acc_z_minus: -8186 This is an example of the output: Event: time [...], type 3 (EV_ABS), code 3 (ABS_RX), value 128610 Event: time [...], type 3 (EV_ABS), code 3 (ABS_RX), value 95747 Event: time [...], type 3 (EV_ABS), code 3 (ABS_RX), value 61321 Event: time [...], type 3 (EV_ABS), code 3 (ABS_RX), value 28864 Event: time [...], type 3 (EV_ABS), code 3 (ABS_RX), value 874 Event: time [...], type 3 (EV_ABS), code 3 (ABS_RX), value -27802 Event: time [...], type 3 (EV_ABS), code 3 (ABS_RX), value -54949 Event: time [...], type 3 (EV_ABS), code 3 (ABS_RX), value -82064 Event: time [...], type 3 (EV_ABS), code 3 (ABS_RX), value -110398 Event: time [...], type 3 (EV_ABS), code 3 (ABS_RX), value -138107 Event: time [...], type 3 (EV_ABS), code 3 (ABS_RX), value -170345 Event: time [...], type 3 (EV_ABS), code 3 (ABS_RX), value -205239 Event: time [...], type 3 (EV_ABS), code 3 (ABS_RX), value -242320 Event: time [...], type 3 (EV_ABS), code 3 (ABS_RX), value -281525 Event: time [...], type 3 (EV_ABS), code 3 (ABS_RX), value -318043 Event: time [...], type 3 (EV_ABS), code 3 (ABS_RX), value -356748 Event: time [...], type 3 (EV_ABS), code 3 (ABS_RX), value -394453 Event: time [...], type 3 (EV_ABS), code 3 (ABS_RX), value -430628 Event: time [...], type 3 (EV_ABS), code 3 (ABS_RX), value -465428 Event: time [...], type 3 (EV_ABS), code 3 (ABS_RX), value -496105 Event: time [...], type 3 (EV_ABS), code 3 (ABS_RX), value -526469 Event: time [...], type 3 (EV_ABS), code 3 (ABS_RX), value -551897 Event: time [...], type 3 (EV_ABS), code 3 (ABS_RX), value -554865 Event: time [...], type 3 (EV_ABS), code 3 (ABS_RX), value -522127 Event: time [...], type 3 (EV_ABS), code 3 (ABS_RX), value -450933 Event: time [...], type 3 (EV_ABS), code 3 (ABS_RX), value -323041 Event: time [...], type 3 (EV_ABS), code 3 (ABS_RX), value -180404 Event: time [...], type 3 (EV_ABS), code 3 (ABS_RX), value -44859 Event: time [...], type 3 (EV_ABS), code 3 (ABS_RX), value 71006 Event: time [...], type 3 (EV_ABS), code 3 (ABS_RX), value 148353 Event: time [...], type 3 (EV_ABS), code 3 (ABS_RX), value 202209 Event: time [...], type 3 (EV_ABS), code 3 (ABS_RX), value 242757 Event: time [...], type 3 (EV_ABS), code 3 (ABS_RX), value 274183 Event: time [...], type 3 (EV_ABS), code 3 (ABS_RX), value 298456 Event: time [...], type 3 (EV_ABS), code 3 (ABS_RX), value 316106 Event: time [...], type 3 (EV_ABS), code 3 (ABS_RX), value 331569 Event: time [...], type 3 (EV_ABS), code 3 (ABS_RX), value 338942 Thanks, Alain