Thread (6 messages) 6 messages, 4 authors, 2022-12-16

Re: [PATCH] cros_ec_keyb: Add 3 buttons for monitor function

From: Prashant Malani <hidden>
Date: 2022-12-15 22:59:00
Also in: chrome-platform, lkml

Hi Joe,

On Wed, Dec 14, 2022 at 10:15 PM Joe Wu
[off-list ref] wrote:
This patch is to add extra 3 buttons: 'brightness up',
'brightness down' and 'leave PC(cros) mode' to support
monitor navigation function.
nit: Please use the imperative form [1] while describing patches.
In this case, that would translate to:
"Add extra 3 buttons..."

Thanks,

-Prashant

[1] https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help