Thread (4 messages) 4 messages, 4 authors, 2022-11-29

Re: [PATCH] Input: elants_i2c - delete some dead code

flat view

From: Doug Anderson <dianders@chromium.org>
Date: 2022-11-28 23:00:17
Also in: kernel-janitors

Hi,

On Tue, Nov 22, 2022 at 10:43 PM Dan Carpenter [off-list ref] wrote:
quoted hunk ↗ jump to hunk
We shuffled the error handling around so this condition is dead code
now.  The "error" variable is always zero.

Signed-off-by: Dan Carpenter <redacted>
---
No Fixes tag because this does not fix a bug but if we were to assign
a tag it would be:

Fixes: a85fbd649844 ("Input: elants_i2c - properly handle the reset GPIO when power is off")

 drivers/input/touchscreen/elants_i2c.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c
index e1308e179dd6..af1dc43e988c 100644
--- a/drivers/input/touchscreen/elants_i2c.c
+++ b/drivers/input/touchscreen/elants_i2c.c
@@ -1353,8 +1353,6 @@ static int elants_i2c_power_on(struct elants_data *ts)
        udelay(ELAN_POWERON_DELAY_USEC);

        gpiod_set_value_cansleep(ts->reset_gpio, 0);
-       if (error)
-               return error;
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help