Thread (3 messages) 3 messages, 2 authors, 2022-11-21

Re: [PATCH v2] HID: hid-sensor-custom: set fixed size for custom attributes

flat view

From: Jiri Kosina <jikos@kernel.org>
Date: 2022-11-21 21:14:28
Also in: linux-iio, lkml

On Thu, 17 Nov 2022, Marcus Folkesson wrote:
This is no bugfix (so no Fixes: tag is necessary) as it is
taken care of in hid_sensor_custom_add_attributes().

The motivation for this patch is that:
hid_sensor_custom_field.attr_name and
hid_sensor_custom_field.attrs
has the size of HID_CUSTOM_TOTAL_ATTRS and used in same context.

We compare against HID_CUSTOM_TOTAL_ATTRS when
looping through hid_custom_attrs.

We will silent the smatch error:
hid_sensor_custom_add_attributes() error: buffer overflow
'hid_custom_attrs' 8 <= 10

Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
Acked-by: Jonathan Cameron <redacted>
Applied to hid.git#for-6.2/sensor. Thanks,

-- 
Jiri Kosina
SUSE Labs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help