Re: [PATCH v1 3/6] dt-bindings: mediatek,mt6779-keypad: add mediatek,double-keys
From: Krzysztof Kozlowski <hidden>
Date: 2022-07-20 17:26:28
Also in:
linux-arm-kernel, linux-devicetree, linux-mediatek, lkml
On 20/07/2022 16:48, Mattijs Korpershoek wrote:
MediaTek keypad has 2 modes of detecting key events: - single key: each (row, column) can detect one key - double key: each (row, column) is a group of 2 keys Currently, only single key detection is supported (by default) Add an optional property, mediatek,double-keys to support double key detection.
You focus here on driver implementation and behavior, but should rather focus on hardware, like - in such setup two keys are physically wired to one (row,column) pin.
quoted hunk ↗ jump to hunk
Double key support exists to minimize cost, since it reduces the number of pins required for physical keys. Signed-off-by: Mattijs Korpershoek <redacted>diff --git a/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml b/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml index ca8ae40a73f7..03c9555849e5 100644 --- a/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml +++ b/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml@@ -49,6 +49,12 @@ properties: maximum: 256 default: 16 + mediatek,double-keys:
Do you think there could be another MT keypad version with triple-keys?
+ description: | + use double key matrix instead of single key + when set, each (row,column) is a group that can detect 2 keys + type: boolean + required: - compatible - reg
Best regards, Krzysztof