Thread (2 messages) 2 messages, 2 authors, 2022-07-15

Re: [PATCH v2] dt-bindings: nvidia,tegra20-kbc: Convert to json-schema

From: Rob Herring <robh@kernel.org>
Date: 2022-07-15 04:10:57
Also in: linux-devicetree, linux-tegra, lkml

On Thu, 14 Jul 2022 17:37:31 +0200, Max Buchholz wrote:
From: Max Buchholz <redacted>

This converts the Nvidia Tegra keyboard controller bindings to YAML
and fix them up a bit.

Reviewed-by: David Heidelberg <david@ixit.cz>
Signed-off-by: Max Buchholz <redacted>
---
 .../bindings/input/nvidia,tegra20-kbc.txt     |  55 ---------
 .../bindings/input/nvidia,tegra20-kbc.yaml    | 109 ++++++++++++++++++
 2 files changed, 109 insertions(+), 55 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/input/nvidia,tegra20-kbc.txt
 create mode 100644 Documentation/devicetree/bindings/input/nvidia,tegra20-kbc.yaml
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/nvidia,tegra20-kbc.example.dtb: kbc@7000e200: nvidia,kbc-row-pins: 'oneOf' conditional failed, one must be fixed:
	[0, 1, 2] is too long
	[0, 1, 2] is too short
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/nvidia,tegra20-kbc.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/nvidia,tegra20-kbc.example.dtb: kbc@7000e200: nvidia,kbc-col-pins: 'oneOf' conditional failed, one must be fixed:
	[11, 12, 13] is too long
	[11, 12, 13] is too short
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/nvidia,tegra20-kbc.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/nvidia,tegra20-kbc.example.dtb: kbc@7000e200: 'linux,keymap' does not match any of the regexes: 'pinctrl-[0-9]+'
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/nvidia,tegra20-kbc.yaml

doc reference errors (make refcheckdocs):
Documentation/devicetree/bindings/power/wakeup-source.txt: Documentation/devicetree/bindings/input/nvidia,tegra20-kbc.txt

See https://patchwork.ozlabs.org/patch/

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help