Re: [PATCH] Input: exc3000 - Fix return value check of wait_for_completion_timeout
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2022-06-29 05:47:13
Also in:
lkml
On Mon, Apr 11, 2022 at 10:58:23AM +0000, Miaoqian Lin wrote:
wait_for_completion_timeout() returns unsigned long not int.
It returns 0 if timed out, and positive if completed.
The check for <= 0 is ambiguous and should be == 0 here
indicating timeout which is the only error case.
Fixes: 102feb1ddfd0 ("Input: exc3000 - factor out vendor data request")
Signed-off-by: Miaoqian Lin <redacted>Applied, thank you. -- Dmitry