Re: [PATCH v3 0/4] Add support for XP-PEN Deco L
From: José Expósito <hidden>
Date: 2022-06-06 10:16:02
Also in:
lkml
Hi, On Tue, May 31, 2022 at 08:12:42PM +0200, José Expósito wrote:
Hello everyone, This patchset adds support for the UGEE XP-PEN Deco L tablet. This device belongs to a family of tablets that must receive a chunk of magic data in order to be enabled (named UGEE v2 internally). [...] --- v1 - Initial version https://lore.kernel.org/linux-input/20220518224702.1409327-1-jose.exposito89@gmail.com/ (local) v2 - Fix some errors reported by the kernel test robot: - Add MODULE_DESCRIPTION/LICENSE/AUTHOR to hid-uclogic-rdesc-test.c - Remove unused variable in uclogic_params_ugee_v2_init - Add sparse __force anotation in the result of cpu_to_le16 - Add DISABLE_STRUCTLEAK_PLUGIN for KUnit tests https://lore.kernel.org/linux-input/20220518224702.1409327-1-jose.exposito89@gmail.com/T/ (local) v3 - This version: - Improve Kconfig message - Add .kunitconfig. Thanks to Daniel Latypov for suggesting it in an unrelated patch: https://lore.kernel.org/dri-devel/CAGS_qxpV2SsihEdgXZ6+7N0dxLmdRANq+qE4iUZ2aNrf6vuLYg@mail.gmail.com/ (local)
As mentioned in the v3 changelog, I'm working on a DRM patch including a few KUnit tests [1]. Some interesting highlights from the comments there: - It looks like the maintainers prefer to include a single symbol [2] to enable all tests in the subsystem. Jiří, Benjamin, how would you like to handle it? Would you prefer to have a symbol for each test (HID_UCLOGIC_KUNIT_TEST)? Or a symbol for all tests (HID_KUNIT_TEST)? - DISABLE_STRUCTLEAK_PLUGIN is not required [3]. I'd also need to remove it here. Jose [1] https://lore.kernel.org/dri-devel/20220530102017.471865-1-jose.exposito89@gmail.com/T/ (local) [2] https://lore.kernel.org/dri-devel/CABVgOSkCxu2xBnxwc6mO2AQaqzTbDf53PJzT2QvZNyLeumt5hg@mail.gmail.com/ (local) [3] https://lore.kernel.org/dri-devel/CAGS_qxpFO4ixW=08ZcdcD9J1kU=B3mwoBJkPW8AKu0sKs8aKfA@mail.gmail.com/ (local)