Thread (101 messages) 101 messages, 7 authors, 2022-05-07

Re: [PATCH 21/48] ARM: pxa: eseries: use gpio lookup for audio

From: Linus Walleij <hidden>
Date: 2022-05-01 21:45:39
Also in: dri-devel, linux-arm-kernel, linux-clk, linux-fbdev, linux-ide, linux-leds, linux-mips, linux-mmc, linux-pm, linux-rtc, linux-usb, lkml

On Tue, Apr 19, 2022 at 6:41 PM Arnd Bergmann [off-list ref] wrote:
From: Arnd Bergmann <arnd@arndb.de>

The three eseries machines have very similar drivers for audio, all
using the mach/eseries-gpio.h header for finding the gpio numbers.

Change these to use gpio descriptors to avoid the header file
dependency.

I convert the _OFF gpio numbers into GPIO_ACTIVE_LOW ones for
consistency here.

Acked-by: Mark Brown <broonie@kernel.org>
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Reviewed-by: Linus Walleij <redacted>
Cc: alsa-devel@alsa-project.org
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Nice use of active low. Maybe I would simply have dropped
the _OFF suffix on these GPIO lines as it can be confusing now
that their active level is encoded but no big deal.
Reviewed-by: Linus Walleij <redacted>

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help