Thread (2 messages) 2 messages, 2 authors, 2022-03-14

[PATCH] Input: mt6779-keypad - fix signedness bug in probe

STALE1665d

From: Dan Carpenter <hidden>
Date: 2022-03-14 14:01:29
Also in: kernel-janitors, linux-mediatek
Subsystem: input (keyboard, mouse, joystick, touchscreen) drivers, mediatek keypad driver, the rest · Maintainers: Dmitry Torokhov, Mattijs Korpershoek, Linus Torvalds

The "irq" variable needs to be signed for the error handling to work.

Fixes: f28af984e771 ("Input: mt6779-keypad - add MediaTek keypad driver")
Signed-off-by: Dan Carpenter <redacted>
---
 drivers/input/keyboard/mt6779-keypad.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/keyboard/mt6779-keypad.c b/drivers/input/keyboard/mt6779-keypad.c
index 5ff23250ed37..abd7e346203d 100644
--- a/drivers/input/keyboard/mt6779-keypad.c
+++ b/drivers/input/keyboard/mt6779-keypad.c
@@ -91,10 +91,10 @@ static void mt6779_keypad_clk_disable(void *data)
 static int mt6779_keypad_pdrv_probe(struct platform_device *pdev)
 {
 	struct mt6779_keypad *keypad;
-	unsigned int irq;
 	u32 debounce;
 	bool wakeup;
 	int error;
+	int irq;
 
 	keypad = devm_kzalloc(&pdev->dev, sizeof(*keypad), GFP_KERNEL);
 	if (!keypad)
-- 
2.20.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help