Thread (20 messages) 20 messages, 4 authors, 2022-03-31

RE:(2) Request for reverting the commit for Samsung HID driver

From: Jiri Kosina <jikos@kernel.org>
Date: 2022-03-30 08:12:00
Also in: stable

On Wed, 30 Mar 2022, 조준완 wrote:
Dear Jiri Kosina,

Thank you for your propt reponse.


Please refer to accossories below.


static const struct hid_device_id samsung_devices[] = {
	{ HID_USB_DEVICE(USB_VENDOR_ID_SAMSUNG, USB_DEVICE_ID_SAMSUNG_IR_REMOTE) },
	{ HID_USB_DEVICE(USB_VENDOR_ID_SAMSUNG, USB_DEVICE_ID_SAMSUNG_WIRELESS_KBD_MOUSE) },
    { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_SAMSUNG_ELECTRONICS, USB_DEVICE_ID_SAMSUNG_WIRELESS_KBD) },
    { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_SAMSUNG_ELECTRONICS, USB_DEVICE_ID_SAMSUNG_WIRELESS_GAMEPAD) },
    { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_SAMSUNG_ELECTRONICS, USB_DEVICE_ID_SAMSUNG_WIRELESS_ACTIONMOUSE) },
    { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_SAMSUNG_ELECTRONICS, USB_DEVICE_ID_SAMSUNG_WIRELESS_UNIVERSAL_KBD) },
    { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_SAMSUNG_ELECTRONICS, USB_DEVICE_ID_SAMSUNG_WIRELESS_MULTI_HOGP_KBD) },
	{ }
};
MODULE_DEVICE_TABLE(hid, samsung_devices);
This is not how the in-kernel driver looks like in Linus' tree though.
Mobile users prefer to use Bluetooth devices instead of USB devices. The 
commit should be reverted for Bluetooth accessories.
Yeah, but the driver in kernel tree doesn't support any Bluetooth devices, 
so there is no need to revert that commit there.

Once you submit your patches to support Bluetooth devices, we'd of course 
have to adjust that condition.

Thanks,

-- 
Jiri Kosina
SUSE Labs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help