Thread (48 messages) 48 messages, 18 authors, 2022-04-01

Re: [PATCH 01/22] orion5x: Replace comments with C99 initializers

From: Segher Boessenkool <hidden>
Date: 2022-03-28 13:38:56
Also in: linux-acpi, linux-edac, linux-gpio, linux-media, linux-pci, linux-rdma, linux-samsung-soc, linux-wireless, linuxppc-dev, lkml, netdev

On Sat, Mar 26, 2022 at 08:23:31PM +0100, Arnd Bergmann wrote:
On Sat, Mar 26, 2022 at 5:58 PM Benjamin Stürz [off-list ref] wrote:
quoted
This replaces comments with C99's designated
initializers because the kernel supports them now.
The change looks fine, but the comment looks misplaced, as enum initializers
are not c99 feature.
Yes, it is from C89/C90.
Also, the named array and struct intializers have been
supported by gnu89 for a long time and widely used in the kernel, so it's
not a recent change even for the others.
GCC supports this since 1998.  There was a syntax different from C99
designated initializers (".ans = 42") before (namely, "ans: 42").

1998 is long enough ago for all intents and purposes now of course ;-)


Segher
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help