RE: [PATCH] Input: trackpoint - Add Suspend mode for Elan TrackPoint
flat view
From: Jingle.Wu <hidden>
Date: 2022-03-24 01:14:28
Also in:
lkml
Loop Josh, Dave. -----Original Message----- From: Dmitry Torokhov [mailto:dmitry.torokhov@gmail.com] Sent: Thursday, March 24, 2022 1:28 AM To: jingle.wu <redacted> Cc: linux-kernel@vger.kernel.org; linux-input@vger.kernel.org; phoenix@emc.com.tw; jingle.wu [off-list ref] Subject: Re: [PATCH] Input: trackpoint - Add Suspend mode for Elan TrackPoint Hi Jingle, On Fri, Sep 04, 2020 at 10:42:31AM +0800, jingle.wu wrote:
From: "jingle.wu" <redacted> Add suspend command for elan trackpoint
Could you please elaborate what this mode does to the trackpint? Also, your signed-off-by is missing.
quoted hunk ↗ jump to hunk
--- drivers/input/mouse/trackpoint.c | 16 ++++++++++++++++ drivers/input/mouse/trackpoint.h | 1 + 2 files changed, 17 insertions(+)diff --git a/drivers/input/mouse/trackpoint.cb/drivers/input/mouse/trackpoint.c index 3eefee2ee2a1..b3cba973a4eb 100644--- a/drivers/input/mouse/trackpoint.c +++ b/drivers/input/mouse/trackpoint.c@@ -389,6 +389,20 @@ static int trackpoint_reconnect(struct psmouse
*psmouse)
quoted hunk ↗ jump to hunk
return 0; } +static void trackpoint_cleanup(struct psmouse *psmouse) { + struct trackpoint_data *tp = psmouse->private; + u8 param[3] = { TP_TOGGLE, TP_TOGGLE_BURST, TP_TOGGLE_ELAN_SLEEP }; + + if (tp->variant_id == TP_VARIANT_ELAN) { + if (ps2_command(&psmouse->ps2dev, param,
I'd combine the 2 "ifs".
+ MAKE_PS2_CMD(3, 0, TP_COMMAND))) {
+ psmouse_err(psmouse,psmouse_warn() since it is not a hard error.
+ "failed to suspend trackpont.\n");
I'd say "failed to suspend Elan trackpont\n".
quoted hunk ↗ jump to hunk
+ } + } +} + int trackpoint_detect(struct psmouse *psmouse, bool set_properties) { struct ps2dev *ps2dev = &psmouse->ps2dev; @@ -421,6 +435,8 @@ int trackpoint_detect(struct psmouse *psmouse, bool set_properties) psmouse->reconnect = trackpoint_reconnect; psmouse->disconnect = trackpoint_disconnect; + psmouse->cleanup = trackpoint_cleanup; + if (variant_id != TP_VARIANT_IBM) { /* Newer variants do not support extended button query. */ button_info = 0x33;diff --git a/drivers/input/mouse/trackpoint.hb/drivers/input/mouse/trackpoint.h index 5cb93ed26085..c7fa75452976 100644--- a/drivers/input/mouse/trackpoint.h +++ b/drivers/input/mouse/trackpoint.h@@ -107,6 +107,7 @@ #define TP_TOGGLE_EXT_TAG 0x22 /* Bit 3 of the first packet coming
from the
external device will be forced to
1 */
#define TP_MASK_EXT_TAG 0x04 +#define TP_TOGGLE_ELAN_SLEEP 0x8
It seems to me that TP_TOGGLE_ELAN_SLEEP is a bit in TP_TOGGLE_BURST subcommand, so it is better to move it next to TP_MASK_BURST and call it TP_MASK_ELAN_SLEEP to match the rest. Thanks. -- Dmitry