RE: [PATCH V3 5/13] hid: use time_is_after_jiffies() instead of open coding it

From
王擎 <hidden>
Date
2022-02-15 09:04:22
Also in
amd-gfx, dm-devel, dri-devel, intel-gfx, linux-block, linux-clk, linux-media, lkml, xen-devel
 
quoted
On Tue, Feb 15, 2022 at 2:56 AM Qing Wang [off-list ref] wrote:

From: Wang Qing <redacted>

Use the helper function time_is_{before,after}_jiffies() to improve
code readability.

Signed-off-by: Wang Qing <redacted>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
FWIW, this one is
Acked-by: Benjamin Tissoires <redacted>

Wang, is there any plan to take this series through the trivial tree
That's why I batch them in a series, but I don't know how to take 
this series through the trivial tree directly.

I would appreciate if you could help.

Thanks,
Wang
or should each maintainer take the matching patches?

Cheers,
Benjamin
quoted
---
 drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/intel-ish-hid/ipc/ipc.c b/drivers/hid/intel-ish-hid/ipc/ipc.c
index 8ccb246..15e1423
--- a/drivers/hid/intel-ish-hid/ipc/ipc.c
+++ b/drivers/hid/intel-ish-hid/ipc/ipc.c
@@ -578,7 +578,7 @@ static void _ish_sync_fw_clock(struct ishtp_device *dev)
        static unsigned long    prev_sync;
        uint64_t        usec;

-       if (prev_sync && jiffies - prev_sync < 20 * HZ)
+       if (prev_sync && time_is_after_jiffies(prev_sync + 20 * HZ))
                return;

        prev_sync = jiffies;
--
2.7.4
Thread (1 message) 1 message, 1 author, last reply 2022-02-15
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help