Thread (16 messages) 16 messages, 3 authors, 2022-02-12

Re: [PATCH V2 5/13] hid: use time_is_after_jiffies() instead of jiffies judgment

From: srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
Date: 2022-02-11 15:46:58
Also in: amd-gfx, dm-devel, dri-devel, intel-gfx, linux-block, linux-clk, linux-media, lkml, xen-devel

On Thu, 2022-02-10 at 18:30 -0800, Qing Wang wrote:
From: Wang Qing <redacted>

It is better to use time_xxx() directly instead of jiffies judgment
for understanding.

Signed-off-by: Wang Qing <redacted>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
quoted hunk ↗ jump to hunk
---
 drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/intel-ish-hid/ipc/ipc.c b/drivers/hid/intel-
ish-hid/ipc/ipc.c
index 8ccb246..15e1423
--- a/drivers/hid/intel-ish-hid/ipc/ipc.c
+++ b/drivers/hid/intel-ish-hid/ipc/ipc.c
@@ -578,7 +578,7 @@ static void _ish_sync_fw_clock(struct
ishtp_device *dev)
        static unsigned long    prev_sync;
        uint64_t        usec;
 
-       if (prev_sync && jiffies - prev_sync < 20 * HZ)
+       if (prev_sync && time_is_after_jiffies(prev_sync + 20 * HZ))
                return;
 
        prev_sync = jiffies;
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help