Re: [PATCH 5/5] spi: make remove callback a void function
From: Mark Brown <broonie@kernel.org>
Date: 2022-02-08 13:40:04
Also in:
alsa-devel, dri-devel, linux-can, linux-clk, linux-fbdev, linux-gpio, linux-hwmon, linux-iio, linux-integrity, linux-leds, linux-media, linux-mmc, linux-omap, linux-rtc, linux-serial, linux-spi, linux-staging, linux-usb, linux-wireless, lkml, netdev, platform-driver-x86
Possibly related (same subject, not in this thread)
- 2022-03-02 · Re: [PATCH 5/5] spi: make remove callback a void function · Pavel Machek <hidden>
- 2022-02-18 · Re: [PATCH 5/5] spi: make remove callback a void function · Hans Verkuil <hidden>
- 2022-01-25 · Re: [PATCH 5/5] spi: make remove callback a void function · Geert Uytterhoeven <geert@linux-m68k.org>
- 2022-01-25 · Re: [PATCH 5/5] spi: make remove callback a void function · Uwe Kleine-König <hidden>
- 2022-01-25 · Re: [PATCH 5/5] spi: make remove callback a void function · Miquel Raynal <miquel.raynal@bootlin.com>
On Sun, Jan 23, 2022 at 06:52:01PM +0100, Uwe Kleine-König wrote:
The value returned by an spi driver's remove function is mostly ignored. (Only an error message is printed if the value is non-zero that the error is ignored.) So change the prototype of the remove function to return no value. This way driver authors are not tempted to assume that passing an error to the upper layer is a good idea. All drivers are adapted accordingly. There is no intended change of behaviour, all callbacks were prepared to return 0 before.
I was going to apply this but it needs rebasing against current code unfortunately.
Attachments
- signature.asc [application/pgp-signature] 488 bytes