[PATCH] HID: add USB_HID dependancy to hid-chicony

Subsystems: hid core layer, the rest

STALE1723d LANDED

Landed in mainline as d080811f2793 on 2021-12-03.

2 messages, 2 authors, 2021-12-03 · open the first message on its own page

[PATCH] HID: add USB_HID dependancy to hid-chicony

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2021-12-03 07:59:36

The chicony HID driver only controls USB devices, yet did not have a
dependancy on USB_HID.  This causes build errors on some configurations
like sparc when building due to new changes to the chicony driver.

Reported-by: Stephen Rothwell <redacted>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <redacted>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/hid/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 828c2995ec34..e9bc8efed5a1 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -207,7 +207,7 @@ config HID_CHERRY
 
 config HID_CHICONY
 	tristate "Chicony devices"
-	depends on HID
+	depends on USB_HID
 	default !EXPERT
 	help
 	Support for Chicony Tactical pad and special keys on Chicony keyboards.
-- 
2.34.1

Re: [PATCH] HID: add USB_HID dependancy to hid-chicony

From: Benjamin Tissoires <hidden>
Date: 2021-12-03 08:44:05

On Fri, Dec 3, 2021 at 8:59 AM Greg Kroah-Hartman
[off-list ref] wrote:
The chicony HID driver only controls USB devices, yet did not have a
dependancy on USB_HID.  This causes build errors on some configurations
like sparc when building due to new changes to the chicony driver.

Reported-by: Stephen Rothwell <redacted>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <redacted>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Applied to for-5.16/upstream-fixes in hid.git

thanks

Cheers,
Benjamin
quoted hunk
---
 drivers/hid/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 828c2995ec34..e9bc8efed5a1 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -207,7 +207,7 @@ config HID_CHERRY

 config HID_CHICONY
        tristate "Chicony devices"
-       depends on HID
+       depends on USB_HID
        default !EXPERT
        help
        Support for Chicony Tactical pad and special keys on Chicony keyboards.
--
2.34.1

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help