Re: [PATCH v2] Input: spaceball - fix parsing of movement data packets

From
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date
2021-12-31 05:10:48
Also in
lkml
Reply to
Leo L. Schwab, 2021-12-21
On Tue, Dec 21, 2021 at 02:16:31AM -0800, Leo L. Schwab wrote:
The spaceball.c module was not properly parsing the movement reports
coming from the device.  The code read axis data as signed 16-bit
little-endian values starting at offset 2.

In fact, axis data in Spaceball movement reports are signed 16-bit
big-endian values starting at offset 3.  This was determined first by
visually inspecting the data packets, and later verified by consulting:
http://spacemice.org/pdf/SpaceBall_2003-3003_Protocol.pdf

If this ever worked properly, it was in the time before Git...

Signed-off-by: Leo L. Schwab <redacted>
Applied, thank you.

-- 
Dmitry
Thread (2 messages) 2 messages, 2 authors, last reply 2021-12-31
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help