HID: intel-ish-hid: ipc: Specify no cache snooping on TGL and ADL

Started by Ye Xiang on Dec 17, 2021 · 3 messages from 3 authors · Last reply Jan 6, 2022

Subsystems (3)

Maintainers (4)

STALE1773d

open the first message on its own page

Ye Xiang

Message details and related content
Open message details and related content
Specify that both TGL and ADL don't support DMA cache snooping.

Signed-off-by: Ye Xiang <redacted>
---
 drivers/hid/intel-ish-hid/ipc/ipc.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/hid/intel-ish-hid/ipc/ipc.c b/drivers/hid/intel-ish-hid/ipc/ipc.c
index 45e0c7b1c9ec..8ccb246b0114 100644
--- a/drivers/hid/intel-ish-hid/ipc/ipc.c
+++ b/drivers/hid/intel-ish-hid/ipc/ipc.c
@@ -909,7 +909,11 @@ static uint32_t ish_ipc_get_header(struct ishtp_device *dev, int length,
  */
 static bool _dma_no_cache_snooping(struct ishtp_device *dev)
 {
-	return dev->pdev->device == EHL_Ax_DEVICE_ID;
+	return (dev->pdev->device == EHL_Ax_DEVICE_ID ||
+		dev->pdev->device == TGL_LP_DEVICE_ID ||
+		dev->pdev->device == TGL_H_DEVICE_ID ||
+		dev->pdev->device == ADL_S_DEVICE_ID ||
+		dev->pdev->device == ADL_P_DEVICE_ID);
 }
 
 static const struct ishtp_hw_ops ish_hw_ops = {
-- 
2.17.1

srinivas pandruvada replied to Ye Xiang

Message details and related content
Open message details and related content
On Fri, 2021-12-17 at 15:45 +0800, Ye Xiang wrote:
Specify that both TGL and ADL don't support DMA cache snooping.

Signed-off-by: Ye Xiang <redacted>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
quoted hunk
---
 drivers/hid/intel-ish-hid/ipc/ipc.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/hid/intel-ish-hid/ipc/ipc.c b/drivers/hid/intel-
ish-hid/ipc/ipc.c
index 45e0c7b1c9ec..8ccb246b0114 100644
--- a/drivers/hid/intel-ish-hid/ipc/ipc.c
+++ b/drivers/hid/intel-ish-hid/ipc/ipc.c
@@ -909,7 +909,11 @@ static uint32_t ish_ipc_get_header(struct
ishtp_device *dev, int length,
  */
 static bool _dma_no_cache_snooping(struct ishtp_device *dev)
 {
-       return dev->pdev->device == EHL_Ax_DEVICE_ID;
+       return (dev->pdev->device == EHL_Ax_DEVICE_ID ||
+               dev->pdev->device == TGL_LP_DEVICE_ID ||
+               dev->pdev->device == TGL_H_DEVICE_ID ||
+               dev->pdev->device == ADL_S_DEVICE_ID ||
+               dev->pdev->device == ADL_P_DEVICE_ID);
 }
 
 static const struct ishtp_hw_ops ish_hw_ops = {





  

    

      
      Jiri Kosina      replied to Ye Xiang      
      
    

  

  

    Message details and related content
    
Open message details and related content

  

  
On Fri, 17 Dec 2021, Ye Xiang wrote:

quoted hunk
Specify that both TGL and ADL don't support DMA cache snooping.

Signed-off-by: Ye Xiang <redacted>
---
 drivers/hid/intel-ish-hid/ipc/ipc.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/hid/intel-ish-hid/ipc/ipc.c b/drivers/hid/intel-ish-hid/ipc/ipc.c
index 45e0c7b1c9ec..8ccb246b0114 100644
--- a/drivers/hid/intel-ish-hid/ipc/ipc.c
+++ b/drivers/hid/intel-ish-hid/ipc/ipc.c
@@ -909,7 +909,11 @@ static uint32_t ish_ipc_get_header(struct ishtp_device *dev, int length,
  */
 static bool _dma_no_cache_snooping(struct ishtp_device *dev)
 {
-	return dev->pdev->device == EHL_Ax_DEVICE_ID;
+	return (dev->pdev->device == EHL_Ax_DEVICE_ID ||
+		dev->pdev->device == TGL_LP_DEVICE_ID ||
+		dev->pdev->device == TGL_H_DEVICE_ID ||
+		dev->pdev->device == ADL_S_DEVICE_ID ||
+		dev->pdev->device == ADL_P_DEVICE_ID);
 }
Applied, thank you.

-- 
Jiri Kosina
SUSE Labs







    
  

  
    

      

        Keyboard shortcuts
      

      

        
          
hback out one level

          
jnext message in thread / next series-diff position

          
kprevious message in thread / previous series-diff position

          
ldrill in

          
Escclose help / fold thread tree

          
?toggle this help