[PATCH] Input: ucb1400_ts: remove redundant variable penup

Subsystems: input (keyboard, mouse, joystick, touchscreen) drivers, the rest

STALE1697d LANDED

Landed in mainline as 53b90bd97670 on 2021-12-20.

2 messages, 2 authors, 2021-12-13 · open the first message on its own page

[PATCH] Input: ucb1400_ts: remove redundant variable penup

From: Colin Ian King <hidden>
Date: 2021-12-05 00:05:32

Variable penup is assigned a value but penup is never read later, it
is redundant and can be removed.

Signed-off-by: Colin Ian King <redacted>
---
 drivers/input/touchscreen/ucb1400_ts.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/input/touchscreen/ucb1400_ts.c b/drivers/input/touchscreen/ucb1400_ts.c
index e3f2c940ef3d..dfd3b35590c3 100644
--- a/drivers/input/touchscreen/ucb1400_ts.c
+++ b/drivers/input/touchscreen/ucb1400_ts.c
@@ -186,7 +186,6 @@ static irqreturn_t ucb1400_irq(int irqnr, void *devid)
 {
 	struct ucb1400_ts *ucb = devid;
 	unsigned int x, y, p;
-	bool penup;
 
 	if (unlikely(irqnr != ucb->irq))
 		return IRQ_NONE;
@@ -196,8 +195,7 @@ static irqreturn_t ucb1400_irq(int irqnr, void *devid)
 	/* Start with a small delay before checking pendown state */
 	msleep(UCB1400_TS_POLL_PERIOD);
 
-	while (!ucb->stopped && !(penup = ucb1400_ts_pen_up(ucb))) {
-
+	while (!ucb->stopped && !ucb1400_ts_pen_up(ucb)) {
 		ucb1400_adc_enable(ucb->ac97);
 		x = ucb1400_ts_read_xpos(ucb);
 		y = ucb1400_ts_read_ypos(ucb);
-- 
2.33.1

Re: [PATCH] Input: ucb1400_ts: remove redundant variable penup

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2021-12-13 05:20:57

On Sun, Dec 05, 2021 at 12:05:25AM +0000, Colin Ian King wrote:
Variable penup is assigned a value but penup is never read later, it
is redundant and can be removed.

Signed-off-by: Colin Ian King <redacted>
Applied, thank you.

-- 
Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help