Re: [PATCH] Input: snvs_pwrkey - Add clk handling

Hi Uwe,

On Tue, Oct 05, 2021 at 10:00:05PM +0200, Uwe Kleine-König wrote:

Hello,

On Wed, Sep 22, 2021 at 11:43:00AM +0200, Uwe Kleine-König wrote:

quoted

On i.MX7S and i.MX8M* (but not i.MX6*) the pwrkey device has an
associated clock. Accessing the registers requires that this clock is
enabled. Binding the driver on at least i.MX7S and i.MX8MP while not
having the clock enabled results in a complete hang of the machine.
(This usually only happens if snvs_pwrkey is built as a module and the
rtc-snvs driver isn't already bound because at bootup the required clk
is on and only gets disabled when the clk framework disables unused clks
late during boot.)

This completes the fix in commit 135be16d3505 ("ARM: dts: imx7s: add
snvs clock to pwrkey").

Signed-off-by: Uwe Kleine-König <redacted>

This patch fixes a hard machine hang that occurs on an i.MX8MP based
machine in ~10% of the boot ups. In my eyes it's suitable to be applied
before v5.14 even.

Any feedback on it?

Sorry for the delay. As you may know I strongly dislike dev_err_probe()
as it conflates the 2 issue - error printing and noting the deferral
event that should be implemented by the resource providers (and I
believe Rob had WIP patches to push this reporting down too providers).

Could you p lease resubmit with "normal" dev_err()/dev_warn()/etc and I
will be happy to apply.

Thanks.

-- 
Dmitry