Re: [PATCH v3 0/4] HID: wiiu-drc: Add a driver for the Wii U gamepad

From
Jiri Kosina <jikos@kernel.org>
Date
2021-10-19 09:14:10
Also in
lkml
Reply to
Emmanuel Gil Peyrot, 2021-09-21
On Tue, 21 Sep 2021, Emmanuel Gil Peyrot wrote:
quoted
This driver is for the DRC (wireless gamepad) when plugged to the DRH of
the Wii U, a chip exposing it as a USB device.
Hi, I’d like to request a review on this series.  I’ve been using it
with success for quite some months, and from a self-review after not
having touched it for as long it still looks correct. :)

Thanks!
[ CCing Daniel ]

Thanks for the patch, and sorry for the delay in the review.

The code looks good to me, the only question/request I'd have is -- would 
it be possible to adhere to the driver naming standards, and actually 
incorporate the support to existing hid-nintendo driver? Or is there any 
substantial reason which I don't see why this wouldn't be a good idea?

Thanks,

-- 
Jiri Kosina
SUSE Labs
Thread (34 messages) 34 messages, 4 authors, 2021-11-05
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help