[PATCH] Input: cpcap-pwrbutton - do not set input parent explicitly

Subsystems: input (keyboard, mouse, joystick, touchscreen) drivers, the rest

STALE1801d LANDED

Landed in mainline as ec45b858c867 on 2021-10-17.

2 messages, 2 authors, 2021-10-16 · open the first message on its own page

[PATCH] Input: cpcap-pwrbutton - do not set input parent explicitly

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2021-10-16 05:26:06 

We are using devm_input_allocate_device() that already sets parent
of the input device, there is no need to do that again.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 drivers/input/misc/cpcap-pwrbutton.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/input/misc/cpcap-pwrbutton.c b/drivers/input/misc/cpcap-pwrbutton.c
index 372cb44d0635..879790bbf9fe 100644
--- a/drivers/input/misc/cpcap-pwrbutton.c
+++ b/drivers/input/misc/cpcap-pwrbutton.c
@@ -77,7 +77,6 @@ static int cpcap_power_button_probe(struct platform_device *pdev)
 
 	button->idev->name = "cpcap-pwrbutton";
 	button->idev->phys = "cpcap-pwrbutton/input0";
-	button->idev->dev.parent = button->dev;
 	input_set_capability(button->idev, EV_KEY, KEY_POWER);
 
 	err = devm_request_threaded_irq(&pdev->dev, irq, NULL,
-- 
2.33.0.1079.g6e70778dc9-goog


-- 
Dmitry

Re: [PATCH] Input: cpcap-pwrbutton - do not set input parent explicitly

From: Sebastian Reichel <hidden>
Date: 2021-10-16 16:03:29 

Hi,

On Fri, Oct 15, 2021 at 10:25:58PM -0700, Dmitry Torokhov wrote:
We are using devm_input_allocate_device() that already sets parent
of the input device, there is no need to do that again.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
Reviewed-by: Sebastian Reichel <redacted>

-- Sebastian
quoted hunk
 drivers/input/misc/cpcap-pwrbutton.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/input/misc/cpcap-pwrbutton.c b/drivers/input/misc/cpcap-pwrbutton.c
index 372cb44d0635..879790bbf9fe 100644
--- a/drivers/input/misc/cpcap-pwrbutton.c
+++ b/drivers/input/misc/cpcap-pwrbutton.c
@@ -77,7 +77,6 @@ static int cpcap_power_button_probe(struct platform_device *pdev)
 
 	button->idev->name = "cpcap-pwrbutton";
 	button->idev->phys = "cpcap-pwrbutton/input0";
-	button->idev->dev.parent = button->dev;
 	input_set_capability(button->idev, EV_KEY, KEY_POWER);
 
 	err = devm_request_threaded_irq(&pdev->dev, irq, NULL,
-- 
2.33.0.1079.g6e70778dc9-goog


-- 
Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help