[PATCH v2] Input: cyttsp - Make use of the helper function dev_err_probe()
STALE1838d
From: Cai Huoqing <hidden>
Date: 2021-09-20 10:33:51
Also in:
lkml
Subsystem:
cyttsp touchscreen driver, input (keyboard, mouse, joystick, touchscreen) drivers, the rest · Maintainers:
Linus Walleij, Dmitry Torokhov, Linus Torvalds
When possible use dev_err_probe help to properly deal with the PROBE_DEFER error, the benefit is that DEFER issue will be logged in the devices_deferred debugfs file. Using dev_err_probe() can reduce code size, and the error value gets printed. Signed-off-by: Cai Huoqing <redacted> --- drivers/input/touchscreen/cyttsp_core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/input/touchscreen/cyttsp_core.c b/drivers/input/touchscreen/cyttsp_core.c
index 01646910c9db..661b9eb4c6a0 100644
--- a/drivers/input/touchscreen/cyttsp_core.c
+++ b/drivers/input/touchscreen/cyttsp_core.c@@ -673,8 +673,7 @@ struct cyttsp *cyttsp_probe(const struct cyttsp_bus_ops *bus_ops, ts->reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW); if (IS_ERR(ts->reset_gpio)) { error = PTR_ERR(ts->reset_gpio); - dev_err_probe(dev, error, "Failed to request reset gpio\n"); - return ERR_PTR(error); + return ERR_PTR(dev_err_probe(dev, error, "Failed to request reset gpio\n")); } error = cyttsp_parse_properties(ts);
--
2.25.1