Thread (2 messages) flat view 2 messages, 1 author, 2021-08-10

Kconfig issue in commit c49c33637802 ("HID: support for initialization of some Thrustmaster wheels")

From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Date: 2021-08-10 05:04:31

Dear Dario, dear Kim, dear Jiri,

In commit c49c33637802 ("HID: support for initialization of some
Thrustmaster wheels"), you have added in ./drivers/hid/Makefile:

obj-$(CONFIG_HID_TMINIT)       += hid-tminit.o

and drivers/hid/hid-quirks.c:

+#if IS_ENABLED(CONFIG_HID_TMINIT)
+       { HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb65d) },
+#endif

However, there is no config HID_TMINIT defined in Kconfig, nor a file
hid-tminit.c.

So, this above is all dead code.

Is this just some unintended leftover from refactoring, or are we
missing a config and the hid-tminit file?

I am happy to provide a patch, once it is what was intended here.

E.g., just drop the line in the Makefile and add the HID_USB_DEVICE
declaration to the CONFIG_HID_THRUSTMASTER ifdef block---if that
works?

Best regards,

Lukas
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help