Thread (4 messages) 4 messages, 3 authors, 2021-08-07

Re: [PATCH] parisc: Make struct parisc_driver::remove() return void

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2021-08-06 18:46:20
Also in: alsa-devel, linux-scsi, linux-serial, netdev

On Fri, Aug 06, 2021 at 11:39:38AM +0200, Uwe Kleine-König wrote:
The caller of this function (parisc_driver_remove() in
arch/parisc/kernel/drivers.c) ignores the return value, so better don't
return any value at all to not wake wrong expectations in driver authors.

The only function that could return a non-zero value before was
ipmi_parisc_remove() which returns the return value of
ipmi_si_remove_by_dev(). Make this function return void, too, as for all
other callers the value is ignored, too.

Also fold in a small checkpatch fix for:

WARNING: Unnecessary space before function pointer arguments
+	void (*remove) (struct parisc_device *dev);

Signed-off-by: Uwe Kleine-König <redacted>
---
...
 drivers/input/keyboard/hilkbd.c          | 4 +---
 drivers/input/serio/gscps2.c             | 3 +--
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Thanks.

-- 
Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help