Thread (4 messages) 4 messages, 2 authors, 2021-07-23

Re: [PATCH] Input: pm8941-pwrkey - fix comma vs semicolon issue

flat view

From: Stephen Boyd <hidden>
Date: 2021-07-23 20:13:01
Also in: lkml

Quoting Dmitry Torokhov (2021-07-23 12:52:15)
On Fri, Jul 23, 2021 at 07:43:52PM +0000, Stephen Boyd wrote:
quoted
Quoting Dmitry Torokhov (2021-07-23 12:39:02)
quoted
There is absolutely no reason to use comma operator in this code, 2
separate statements make much more sense.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
Fixes: 2fcbda9a822d ("Input: pm8941-pwrkey - add support for PMK8350
PON_HLOS PMIC peripheral")
It actually predates this patch and also not really a fix as the
original code ends up working properly, but looks weird.
Alright.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help