Re: [PATCH] HID: intel-ish-hid: use async resume function

From
Jiri Kosina <jikos@kernel.org>
Date
2021-07-15 19:00:55
Also in
linux-iio, lkml
Reply to
Ye Xiang, 2021-06-13
On Sun, 13 Jun 2021, Ye Xiang wrote:
ISH IPC driver uses asynchronous workqueue to do resume now, but there is
a potential timing issue: when child devices resume before bus driver, it
will cause child devices resume failed and cannot be recovered until
reboot. The current implementation in this case do wait for IPC to resume
but fail to accommodate for a case when there is no ISH reboot and soft
resume is taking time. This issue is apparent on Tiger Lake platform with
5.11.13 kernel when doing suspend to idle then resume(s0ix) test. To
resolve this issue, we change ISHTP HID client to use asynchronous resume
callback too. In the asynchronous resume callback, it waits for the ISHTP
resume done event, and then notify ISHTP HID client link ready.

Signed-off-by: Ye Xiang <redacted>
Applied, thank you.

-- 
Jiri Kosina
SUSE Labs
Thread (6 messages) 6 messages, 3 authors, last reply 2021-07-15
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help