Re: [PATCH] HID: input: do not report stylus battery state as "full"
flat view
From: Kenneth Albanowski <hidden>
Date: 2021-06-29 22:07:39
Also in:
lkml
I've tested it on a 5.4 derivative, and that works as expected. Looks good to me. - Kenneth Albanowski - Kenneth On Tue, Jun 29, 2021 at 11:25 AM Dmitry Torokhov [off-list ref] wrote:
quoted hunk ↗ jump to hunk
The power supply states of discharging, charging, full, etc, represent state of charging, not the capacity level of the battery (for which we have a separate property). Current HID usage tables to not allow for expressing charging state of the batteries found in generic styli, so we should simply assume that the battery is discharging even if current capacity is at 100% when battery strength reporting is done via HID interface. In fact, we were doing just that before commit 581c4484769e. This change helps UIs to not mis-represent fully charged batteries in styli as being charging/topping-off. Fixes: 581c4484769e ("HID: input: map digitizer battery usage") Reported-by: Kenneth Albanowski <redacted> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> --- drivers/hid/hid-input.c | 2 -- 1 file changed, 2 deletions(-)diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c index e982d8173c9c..e85a1a34ff39 100644 --- a/drivers/hid/hid-input.c +++ b/drivers/hid/hid-input.c@@ -417,8 +417,6 @@ static int hidinput_get_battery_property(struct power_supply *psy, if (dev->battery_status == HID_BATTERY_UNKNOWN) val->intval = POWER_SUPPLY_STATUS_UNKNOWN; - else if (dev->battery_capacity == 100) - val->intval = POWER_SUPPLY_STATUS_FULL; else val->intval = POWER_SUPPLY_STATUS_DISCHARGING; break; --2.32.0.93.g670b81a890-goog -- Dmitry