Thread (4 messages) 4 messages, 3 authors, 2021-06-07

Re: [PATCH v2] MOUSE_ATARI: fix kconfig unmet dependency warning

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2021-06-07 14:36:38
Also in: linux-m68k, lkml

Hi Dmitry,

On Wed, Jun 2, 2021 at 6:15 AM Dmitry Torokhov
[off-list ref] wrote:
On Thu, May 27, 2021 at 08:56:30AM +0200, Geert Uytterhoeven wrote:
quoted
On Thu, May 27, 2021 at 2:12 AM Randy Dunlap [off-list ref] wrote:
quoted
Since the code for ATARI_KBD_CORE does not use drivers/input/keyboard/
code, just move ATARI_KBD_CORE to arch/m68k/Kconfig.machine to remove
this dependency.

Removes this kconfig warning:

WARNING: unmet direct dependencies detected for ATARI_KBD_CORE
  Depends on [n]: !UML && INPUT [=y] && INPUT_KEYBOARD [=n]
  Selected by [y]:
  - MOUSE_ATARI [=y] && !UML && INPUT [=y] && INPUT_MOUSE [=y] && ATARI [=y]

Fixes: c04cb856e20a ("m68k: Atari keyboard and mouse support.")
Signed-off-by: Randy Dunlap <redacted>
Cc: Michael Schmitz <redacted>
Cc: Roman Zippel <redacted>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org
Cc: linux-m68k@lists.linux-m68k.org
Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
Suggested-by: Michael Schmitz <schmitzmic@gmail.com>
quoted
---
v2: move the symbol outside of INPUT_KEYBOARD (Geert) -- all the way
    to Kconfig.machine (Michael). Thanks.
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

I'm willing to queue this in the m68k for-v5.14 branch, if Dmitry agrees.
Sure, works for me.

Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Thanks,  queue in the m68k for-v5.14 branch.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help