Re: [PATCH V3 4/5] dt-bindings: input: pm8941-pwrkey: Convert pm8941 power key binding to yaml

On 2021-06-02 10:07, Dmitry Torokhov wrote:

On Wed, May 12, 2021 at 10:17:43AM +0530, skakit@codeaurora.org wrote:

quoted

On 2021-05-10 21:54, Rob Herring wrote:

quoted

On Mon, May 10, 2021 at 09:01:39AM -0500, Rob Herring wrote:

quoted

On Mon, 10 May 2021 12:31:03 +0530, satya priya wrote:

quoted

Convert qcom pm8941 power key binding from .txt to .yaml format.

Signed-off-by: satya priya <redacted>
---
Changes in V2:
 - Fixed bot errors, took reference from input.yaml for "linux,code"
 - Added one complete example for powerkey and resin, and referenced it
   in main PON binding.
 - Moved this patch to the end of the series.

Changes in V3:
 - Moved this patch before PON binding patch.
 - As per Rob's comments, added allOf at the beginning of binding.
   Added maxItems for interrupts.
 - Added 'unevaluatedProperties' instead of 'additionalProperties' as
   we are using allOf.

 .../bindings/input/qcom,pm8941-pwrkey.txt          | 55 --------------
 .../bindings/input/qcom,pm8941-pwrkey.yaml         | 87 ++++++++++++++++++++++
 2 files changed, 87 insertions(+), 55 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.txt
 create mode 100644 Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.yaml

My bot found errors running 'make DT_CHECKER_FLAGS=-m
dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.example.dt.yaml:0:0:
/example-0/spmi@c440000/pmic@0/pon_hlos@1300: failed to match any
schema with compatible: ['qcom,pm8998-pon']

You have the same example in patch 5, so drop the example here. That
will fix this circular dependency.

Earlier I have dropped example from qcom-pon.yaml. Now, I will add the
example there and drop here.

It sounds to me you want to combine patches 4 and 5 since they depend 
on
each other.

No, the idea was to have one complete example, instead of bits. So, 
initially I have removed the example part from qcom-pon.yaml and added 
full example here, but it was causing a circular dependency issue. Rob 
suggested to move it back to qcom-pon.yaml to fix issue.

I have posted V4 making that change.
https://lore.kernel.org/patchwork/patch/1425638/

Thanks,
Satya Priya

Thanks.