[PATCH] HID: usbhid: hid-pidff: Fix missing error code in hid_pidff_init()
flat view
STALE1933d
From: Jiapeng Chong <hidden>
Date: 2021-06-01 11:05:37
Also in:
linux-usb, lkml
Subsystem:
hid core layer, the rest, usb hid pid drivers (usb wheelbases, joysticks, rudders, ...), usb hid/hidbp drivers (usb keyboards, mice, remote controls, ...) · Maintainers:
Jiri Kosina, Benjamin Tissoires, Linus Torvalds, Tomasz Pakuła, Oleg Makarenko
The error code is missing in this code scenario, add the error code '-EINVAL' to the return value 'error'. Eliminate the follow smatch warning: drivers/hid/usbhid/hid-pidff.c:1297 hid_pidff_init() warn: missing error code 'error'. Reported-by: Abaci Robot <redacted> Signed-off-by: Jiapeng Chong <redacted> --- drivers/hid/usbhid/hid-pidff.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c
index ea126c5..731b49e 100644
--- a/drivers/hid/usbhid/hid-pidff.c
+++ b/drivers/hid/usbhid/hid-pidff.c@@ -1294,6 +1294,7 @@ int hid_pidff_init(struct hid_device *hid) pidff->pool[PID_DEVICE_MANAGED_POOL].value[0] == 0) { hid_notice(hid, "device does not support device managed pool\n"); + error = -EINVAL; goto fail; }
--
1.8.3.1