Thread (9 messages) flat view 9 messages, 5 authors, 2021-05-11
STALE1955d

[PATCH] Input: tsc200x: Drop hard-coded IRQ edge

From: Linus Walleij <hidden>
Date: 2021-05-09 23:38:38
Subsystem: input (keyboard, mouse, joystick, touchscreen) drivers, the rest · Maintainers: Dmitry Torokhov, Linus Torvalds

This edge setting should come from the device tree not
the driver. Also, most device trees sets this to the
falling edge, which is contradictory to what is hardcoded.

Signed-off-by: Linus Walleij <redacted>
---
 drivers/input/touchscreen/tsc200x-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/tsc200x-core.c b/drivers/input/touchscreen/tsc200x-core.c
index ce2fe30d6b8a..5f0ce663a2dc 100644
--- a/drivers/input/touchscreen/tsc200x-core.c
+++ b/drivers/input/touchscreen/tsc200x-core.c
@@ -540,7 +540,7 @@ int tsc200x_probe(struct device *dev, int irq, const struct input_id *tsc_id,
 
 	error = devm_request_threaded_irq(dev, irq, NULL,
 					  tsc200x_irq_thread,
-					  IRQF_TRIGGER_RISING | IRQF_ONESHOT,
+					  IRQF_ONESHOT,
 					  "tsc200x", ts);
 	if (error) {
 		dev_err(dev, "Failed to request irq, err: %d\n", error);
-- 
2.30.2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help