Re: [PATCH 1/3] HID: asus: Cleanup Asus T101HA keyboard-dock handling

From
Benjamin Tissoires <hidden>
Date
2021-05-05 13:36:20
Reply to
Jiri Kosina, 2021-05-05
On Wed, May 5, 2021 at 2:24 PM Jiri Kosina [off-list ref] wrote:
On Wed, 31 Mar 2021, Jiri Kosina wrote:
quoted
quoted
There is no need to use a quirk and then return -ENODEV from the
asus_probe() function to avoid that hid-asus binds to the hiddev
for the USB-interface for the hid-multitouch touchpad.

The hid-multitouch hiddev has a group of HID_GROUP_MULTITOUCH_WIN_8,
so the same result can be achieved by making the hid_device_id entry
for the dock in the asus_devices[] table only match on HID_GROUP_GENERIC
instead of having it match HID_GROUP_ANY.
Benjamin, could you please Ack this series, as it touches hid-multitouch,
please?
Benjamin, friendly ping on this one.
Sorry for being such a bad co-maintainer... :(

This one completely fell through the cracks.

I have no objections for 1/3 and 2/3. I'll comment on 3/3.

Cheers,
Benjamin
Thread (11 messages) 11 messages, 3 authors, last reply 2021-05-13
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help