Re: [PATCH] Input: ili210x - add missing negation for touch indication on ili210x
From: Marek Vasut <marex@denx.de>
Date: 2021-05-06 17:51:06
Also in:
lkml
On 5/6/21 7:32 PM, Hansem Ro wrote:
quoted hunk
This adds the negation needed for proper finger detection on Ilitek ili2107/ili210x. This fixes the polling and coordinate parsing issues (on Amazon Kindle Fire) caused by returning false for the cooresponding finger on the touchscreen. Signed-off-by: Hansem Ro <redacted> --- drivers/input/touchscreen/ili210x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/input/touchscreen/ili210x.c b/drivers/input/touchscreen/ili210x.c index d8fccf048bf4..30576a5f2f04 100644 --- a/drivers/input/touchscreen/ili210x.c +++ b/drivers/input/touchscreen/ili210x.c@@ -87,7 +87,7 @@ static bool ili210x_touchdata_to_coords(const u8 *touchdata, unsigned int *x, unsigned int *y, unsigned int *z) { - if (touchdata[0] & BIT(finger)) + if (!(touchdata[0] & BIT(finger)))
This makes the behavior consistent with the other ILI21xx touchscreen controllers too, so I think this patch is OK, thanks. It would be nice if you could add Fixes: tag, so this could get picked into linux-stable too.