Thread (12 messages) 12 messages, 2 authors, 2021-07-01

Re: [PATCH 0/7] Input: goodix - Add support for controllers without flash

From: Bastien Nocera <hadess@hadess.net>
Date: 2021-04-28 12:03:46

On Wed, 2021-04-28 at 13:46 +0200, Hans de Goede wrote:
Hi All,

A while ago I bought a Glavey TM800A550L tablet. This is a Bay Trail
(x86)
tablet which comes with Android from the factory.

It is mostly just another Bay Trail tablet, but the way the Goodix
touchscreen on it works is interesting. The controller needs to have
firmware uploaded to it before it will work. After that it pretty
much
works 100% the same as any other Goodix touchscreen controller.

I've described this patch-set in the Subject as "Add support for
controllers without flash", but I suspect that the Goodix controllers
used on Bay Trail devices which ship with Windows pre-installed may
also
lack flash; and that the Windows version of the BIOS-es on these
devices
does the upload for us. Anyways just something which I'm wondering
about,
these patches are necessary to make things work regardless.

These patches should also be useful for supporting the Goodix
controllers
on some ARM based devices, as some of those need the OS to upload the
firmware too AFAIK.

Note patch 7/7 is included to get an overview of the entire set.
I'll merge that one myself through the pdx86 tree. Patches 1-6 are
intended for merging through the input tree.

I've done a cursory review, and didn't find anything particularly
egregious. Did you check that the intermediate patches all compiled?
Feel free to add my Reviewed-by:

My only question would be where the firmware are supposed to come from
after this gets merged.

Cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help