[PATCH] Input: twl4030_keypad - Fix missing IRQF_ONESHOT as only threaded handler
From: <hidden>
Date: 2021-04-16 02:57:53
Also in:
lkml
Subsystem:
input (keyboard, mouse, joystick, touchscreen) drivers, the rest · Maintainers:
Dmitry Torokhov, Linus Torvalds
From: Guangqing Zhu <redacted> Coccinelle noticed: drivers/input/keyboard/twl4030_keypad.c:413:9-34: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT Signed-off-by: Guangqing Zhu <redacted> --- drivers/input/keyboard/twl4030_keypad.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/keyboard/twl4030_keypad.c b/drivers/input/keyboard/twl4030_keypad.c
index 77e0743a3cf8..05057ebb1ab2 100644
--- a/drivers/input/keyboard/twl4030_keypad.c
+++ b/drivers/input/keyboard/twl4030_keypad.c@@ -411,7 +411,7 @@ static int twl4030_kp_probe(struct platform_device *pdev) * NOTE: we assume this host is wired to TWL4040 INT1, not INT2 ... */ error = devm_request_threaded_irq(&pdev->dev, kp->irq, NULL, do_kp_irq, - 0, pdev->name, kp); + IRQF_ONESHOT, pdev->name, kp); if (error) { dev_info(kp->dbg_dev, "request_irq failed for irq no=%d: %d\n", kp->irq, error);
--
2.17.1