Re: [PATCH 2/2] Input: evbug - Use 'pr_debug()' instead of hand-writing it
From: Joe Perches <joe@perches.com>
Date: 2021-04-15 23:52:40
Also in:
kernel-janitors, lkml
On Thu, 2021-04-15 at 22:58 +0200, Christophe JAILLET wrote:
'printk(KERN_DEBUG pr_fmt(...))' can be replaced by a much less verbose 'pr_debug()'.
This is not really true because printk(KERN_DEBUG ...); will _always_ be emitted if the console level allows pr_debug(...); will _only_ be emitted if the console level allows _and_ DEBUG is defined or dynamic_debug is enabled (and for dynamic_debug, only if specifically enabled) DEBUG is defined and dynamic_debug is enabled
quoted hunk ↗ jump to hunk
diff --git a/drivers/input/evbug.c b/drivers/input/evbug.c
[]
quoted hunk ↗ jump to hunk
@@ -21,8 +21,8 @@ MODULE_LICENSE("GPL");static void evbug_event(struct input_handle *handle, unsigned int type, unsigned int code, int value) { - printk(KERN_DEBUG pr_fmt("Event. Dev: %s, Type: %d, Code: %d, Value: %d\n"), - dev_name(&handle->dev->dev), type, code, value); + pr_debug("Event. Dev: %s, Type: %d, Code: %d, Value: %d\n", + dev_name(&handle->dev->dev), type, code, value); }