Re: [PATCH v4 1/2] mfd: google,cros-ec: add DT bindings for a baseboard's switch device

On Tue, Apr 13, 2021 at 10:57 PM Rob Herring [off-list ref] wrote:

On Mon, Apr 12, 2021 at 07:30:19PM +0800, Ikjoon Jang wrote:

quoted

This is for ChromeOS tablets which have a 'cros_cbas' switch device
in the "Whiskers" base board. This device can be instantiated only by
device tree on ARM platforms. ChromeOS EC doesn't provide a way to
probe the device.

Signed-off-by: Ikjoon Jang <redacted>

---

Changes in v4:
Define cros-cbase bindings inside google,cros-ec.yaml instead of
a seperated binding document.

 .../devicetree/bindings/mfd/google,cros-ec.yaml  | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
index 76bf16ee27ec..c76809cd9f7f 100644
--- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
+++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml

@@ -127,6 +127,18 @@ patternProperties:
     type: object
     $ref: "/schemas/extcon/extcon-usbc-cros-ec.yaml#"

+  "^cbas$":

Not a pattern, put under 'properties'.

quoted

+    type: object
+    properties:
+      compatible:
+        const: google,cros-cbas

Blank line

quoted

+    required:
+      - compatible

Blank line

quoted

+    additionalProperties: false
+    description:

Make this 1st or at least before 'properties'.

ACKed, thanks!

quoted

+      This device is used to signal when a detachable base is attached
+      to a Chrome OS tablet.

This can't happen at runtime?

There is no way to detect the switch device's existence at runtime.
I'll add a note to the description about this.

quoted

+
 required:
   - compatible

@@ -180,6 +192,10 @@ examples:
             interrupts = <99 0>;
             interrupt-parent = <&gpio7>;
             spi-max-frequency = <5000000>;
+
+            base_detection: cbas {
+                compatible = "google,cros-cbas";
+            };
         };
     };

--

2.31.1.295.g9ea45b61b8-goog