Re: [PATCH] HID: hid-sensor-custom: remove useless variable
From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Date: 2021-04-09 18:19:18
Also in:
linux-iio, lkml
On Fri, 2021-04-09 at 15:15 +0800, Jiapeng Chong wrote:
Fix the following gcc warning: drivers/hid/hid-sensor-custom.c:400:7: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]. Reported-by: Abaci Robot <redacted> Signed-off-by: Jiapeng Chong <redacted>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com
quoted hunk ↗ jump to hunk
--- drivers/hid/hid-sensor-custom.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)diff --git a/drivers/hid/hid-sensor-custom.c b/drivers/hid/hid-sensor-custom.c index 2628bc5..e430673 100644--- a/drivers/hid/hid-sensor-custom.c +++ b/drivers/hid/hid-sensor-custom.c@@ -397,15 +397,14 @@ static ssize_t store_value(struct device *dev,struct device_attribute *attr, if (!strncmp(name, "value", strlen("value"))) { u32 report_id; - int ret; if (kstrtoint(buf, 0, &value) != 0) return -EINVAL; report_id = sensor_inst->fields[field_index].attribute. report_ id; - ret = sensor_hub_set_feature(sensor_inst->hsdev, report_id, - index, sizeof(value), &value); + sensor_hub_set_feature(sensor_inst->hsdev, report_id, index, + sizeof(value), &value); } else return -EINVAL;