Re: [PATCH] Input: cyttsp - Verbose error on soft reset

On Tue, Mar 23, 2021 at 4:57 AM Dmitry Torokhov
[off-list ref] wrote:

On Mon, Mar 22, 2021 at 11:13:49PM +0100, Linus Walleij wrote:

quoted

      retval = timeout ? 0 : -EIO;
+     if (retval)
+             dev_err(ts->dev, "timeout waiting for soft reset\n");

I think if we have conditional for the error message then having ternary
above does not make sense. I changed this to:

Ah nice.

I'm starting to get this driver to work on a machine, so I hope I
will be able to make a few more serious improvements.

Yours,
Linus Walleij