On Tue, Mar 9, 2021 at 12:27 AM Dmitry Torokhov
[off-list ref] wrote:
On Mon, Mar 08, 2021 at 11:55:07PM +0200, Andy Shevchenko wrote:
...
quoted
+ ts->get_pendown_state = tsc2007_get_pendown_state_gpio;
OK, I know what my concern was here. You are now assigning
ts->get_pendown_state unconditionally, and with ts->gpiod being NULL it
will always return false, whereas the old code would skip setting
ts->get_pendown_state when GPIO is not available, and the driver would
assume that on interrupt the pen is actually down.
Good catch!
I fixed this in v3 (left original conditional, if we want to drop the
warning, then we may do it in a separate change).
--
With Best Regards,
Andy Shevchenko